From a89a3013f9c920c802f9892df4a76755aae79bcd Mon Sep 17 00:00:00 2001 From: Abhinav Sarkar Date: Mon, 11 Jul 2016 19:00:59 +0530 Subject: [PATCH] Fixes a typo in a setting name. --- ringo-app/src/Main.hs | 2 +- ringo-app/src/Ringo/ArgParser.hs | 2 +- ringo/src/Ringo/Types/Internal.hs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ringo-app/src/Main.hs b/ringo-app/src/Main.hs index 21921e9..5d53bb2 100644 --- a/ringo-app/src/Main.hs +++ b/ringo-app/src/Main.hs @@ -45,7 +45,7 @@ writeFiles outputDir env = do . foldl (\acc -> Map.union acc . extractDependencies env) Map.empty $ facts - BS.writeFile (outputDir Text.unpack settingDimensionJSONFileName) . encode $ + BS.writeFile (outputDir Text.unpack settingDimensionsJSONFileName) . encode $ [ tableName table | (_, tabs) <- dimTables, table <- tabs , table `notElem` tables ] BS.writeFile (outputDir Text.unpack settingFactsJSONFileName) . encode $ diff --git a/ringo-app/src/Ringo/ArgParser.hs b/ringo-app/src/Ringo/ArgParser.hs index b82162c..56b10dd 100644 --- a/ringo-app/src/Ringo/ArgParser.hs +++ b/ringo-app/src/Ringo/ArgParser.hs @@ -76,7 +76,7 @@ settingsParser = let Settings {..} = defSettings settingFactsJSONFileName "Name of the output facts json file" <*> minorOption "dimensions-json-file" - settingDimensionJSONFileName + settingDimensionsJSONFileName "Name of the output dimensions json file" <*> option auto (long "foreign-key-id-coalesce-val" <> hidden diff --git a/ringo/src/Ringo/Types/Internal.hs b/ringo/src/Ringo/Types/Internal.hs index 57124ff..f9db38c 100644 --- a/ringo/src/Ringo/Types/Internal.hs +++ b/ringo/src/Ringo/Types/Internal.hs @@ -372,7 +372,7 @@ data Settings = Settings -- | Name of the generated JSON file containing the list of name of the generated fact tables , settingFactsJSONFileName :: !Text -- | Name of the generated JSON file containing the list of name of the generated dimension tables - , settingDimensionJSONFileName :: !Text + , settingDimensionsJSONFileName :: !Text -- | Value to coalesce the missing foreign key id column values to in the generated fact tables , settingForeignKeyIdCoalesceValue :: !Int -- | Suffix template for names of all the generated tables @@ -394,7 +394,7 @@ defSettings = Settings , settingFactInfix = "_by_" , settingDependenciesJSONFileName = "dependencies.json" , settingFactsJSONFileName = "facts.json" - , settingDimensionJSONFileName = "dimensions.json" + , settingDimensionsJSONFileName = "dimensions.json" , settingForeignKeyIdCoalesceValue = -1 , settingTableNameSuffixTemplate = "{{suff}}" }