abhin4v
/
ringo
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixes a typo in a setting name.

pull/1/head
Abhinav Sarkar 2016-07-04 17:09:04 +05:30
parent 207b11bee1
commit 11e7d7d3b2
No known key found for this signature in database
GPG Key ID: 7C9166A6F5465AD5
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ringo-app/src/Ringo/ArgParser.hs
View File

@ -43,7 +43,7 @@ settingsParser = let Settings {..} = defSettings
<> help ("Time unit granularity for fact tables. Possible values: "
++ intercalate ", " timeunits))
<*> minorOption "avg-count-col-suffix"
settingAvgCountColumSuffix
settingAvgCountColumnSuffix
"Suffix for average count columns"
<*> minorOption "avg-sum-col-suffix"
settingAvgSumColumnSuffix

2
ringo/src/Ringo/Extractor.hs
View File

@ -45,7 +45,7 @@ extractFactTable fact = do
FactMax {..} -> [ notNullSourceColumnRename factColSourceColumn cName ]
FactMin {..} -> [ notNullSourceColumnRename factColSourceColumn cName ]
FactAverage {..} ->
[ Column (cName <> settingAvgCountColumSuffix) countColType NotNull
[ Column (cName <> settingAvgCountColumnSuffix) countColType NotNull
, notNullSourceColumnRename factColSourceColumn (cName <> settingAvgSumColumnSuffix)
]
_ -> []

2
ringo/src/Ringo/Generator/Populate/Fact.hs
View File

@ -162,7 +162,7 @@ factTablePopulateStmts popMode fact = do
FactMax {..} -> [ (cName, app' "max" factColSourceColumn, False) ]
FactMin {..} -> [ (cName, app' "min" factColSourceColumn, False) ]
FactAverage {..} ->
[ ( cName <> settingAvgCountColumSuffix, app' "count" factColSourceColumn, False )
[ ( cName <> settingAvgCountColumnSuffix, app' "count" factColSourceColumn, False )
, ( cName <> settingAvgSumColumnSuffix , app' "sum" factColSourceColumn , False)
]
_ -> []

4
ringo/src/Ringo/Types/Internal.hs
View File

@ -121,7 +121,7 @@ data Settings = Settings
{ settingDimPrefix :: !Text
, settingFactPrefix :: !Text
, settingTimeUnit :: !TimeUnit
, settingAvgCountColumSuffix :: !Text
, settingAvgCountColumnSuffix :: !Text
, settingAvgSumColumnSuffix :: !Text
, settingDimTableIdColumnName :: !Text
, settingDimTableIdColumnType :: !Text
@ -140,7 +140,7 @@ defSettings = Settings
{ settingDimPrefix = "dim_"
, settingFactPrefix = "fact_"
, settingTimeUnit = Minute
, settingAvgCountColumSuffix = "_count"
, settingAvgCountColumnSuffix = "_count"
, settingAvgSumColumnSuffix = "_sum"
, settingDimTableIdColumnName = "id"
, settingDimTableIdColumnType = "serial"