close reader on deserialize, add a test

.classpath

@@ -6,5 +6,8 @@
 	<classpathentry kind="lib" path="lib/default/hadoop-core.jar"/>
 	<classpathentry kind="lib" path="lib/default/hive-exec.jar"/>
 	<classpathentry kind="lib" path="lib/default/opencsv.jar"/>
+	<classpathentry kind="lib" path="lib/test/junit.jar"/>
+	<classpathentry kind="lib" path="lib/buildtime/log4j.jar"/>
+	<classpathentry kind="lib" path="lib/test/commons-logging.jar"/>
 	<classpathentry kind="output" path="target/classes"/>
 </classpath>

ivy.xml

@@ -34,6 +34,7 @@
     <dependency org="cobertura" name="cobertura" rev="1.9.4.1" conf="buildtime->default"/>
 
     <!-- test time only dependencies -->
+    <dependency org="apache" name="commons-logging" rev="1.1.1" conf="test->default" />    
     <dependency org="junit" name="junit" rev="4.8.2" conf="test->default"/>
   </dependencies>
 </ivy-module>

src/main/java/com/bizo/hive/serde/csv/CSVSerde.java

@@ -35,9 +35,9 @@ import au.com.bytecode.opencsv.CSVWriter;
 public final class CSVSerde implements SerDe {
   
   private ObjectInspector inspector;
-  String[] outputFields;
-  int numCols;
-  List<String> row;
+  private String[] outputFields;
+  private int numCols;
+  private List<String> row;
   
   @Override
   public void initialize(final Configuration conf, final Properties tbl) throws SerDeException {
@@ -102,8 +102,9 @@ public final class CSVSerde implements SerDe {
   public Object deserialize(final Writable blob) throws SerDeException {
     Text rowText = (Text) blob;
     
+    CSVReader csv = null;
     try {
-      final CSVReader csv = new CSVReader(new CharArrayReader(rowText.toString().toCharArray()));
+      csv = new CSVReader(new CharArrayReader(rowText.toString().toCharArray()));
       final String[] read = csv.readNext();
       
       for (int i=0; i< numCols; i++) {
@@ -117,6 +118,14 @@ public final class CSVSerde implements SerDe {
       return row;
     } catch (final Exception e) {
       throw new SerDeException(e);
+    } finally {
+      if (csv != null) {
+        try {
+          csv.close();
+        } catch (final Exception e) {
+          // ignore
+        }
+      }
     }
   }
 

src/test/java/com/bizo/hive/serde/csv/CSVSerdeTest.java

@@ -0,0 +1,35 @@
+package com.bizo.hive.serde.csv;
+
+import java.util.List;
+import java.util.Properties;
+
+import org.apache.hadoop.hive.serde.Constants;
+import org.apache.hadoop.io.Text;
+import org.junit.Before;
+import org.junit.Test;
+import static org.junit.Assert.assertEquals;
+
+
+public final class CSVSerdeTest {
+  private final CSVSerde csv = new CSVSerde();
+  
+  @Before
+  public void setup() throws Exception {
+    final Properties props = new Properties();
+    props.put(Constants.LIST_COLUMNS, "a,b,c");
+    props.put(Constants.LIST_COLUMN_TYPES, "string,string,string");
+    
+    csv.initialize(null, props);
+  }
+  
+  @Test
+  public void testDeserialize() throws Exception {
+    final Text in = new Text("hello,\"yes, okay\",1");
+    
+    final List<String> row = (List<String>) csv.deserialize(in);
+    
+    assertEquals("hello", row.get(0));
+    assertEquals("yes, okay", row.get(1));
+    assertEquals("1", row.get(2));
+  }
+}